Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal support for ROS2 #123

Merged
merged 16 commits into from
Apr 17, 2024
Merged

Add minimal support for ROS2 #123

merged 16 commits into from
Apr 17, 2024

Conversation

gonzalocasas
Copy link
Member

This PR builds up on #120 but makes it a non-breaking change instead. Added ROS2 to the CI tests also, although only testing one tiny part of ROS2 so far.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke check).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@gonzalocasas
Copy link
Member Author

@iliabaranov I've moved your fix to a roslibpy.ros2.Header class and now everything seems to work on both ROS1 and ROS2. I will merge and cut a new release with this.

@gonzalocasas gonzalocasas merged commit c9bfdf8 into main Apr 17, 2024
8 checks passed
@gonzalocasas gonzalocasas deleted the ros2 branch April 17, 2024 11:31
@iliabaranov
Copy link
Contributor

Cheers, thanks! :D

@gonzalocasas
Copy link
Member Author

I'll try to add actionlib support soon and fix the rest of the tests

@gonzalocasas
Copy link
Member Author

Please let me know if you encounter any issues in the meantime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants